search

Taiko2k / Tauon

The music player of today! :city_sunrise:
https://tauonmusicbox.rocks
GNU General Public License v3.0
1.64k stars 64 forks source link

replace isounidecode with unidecode #1164

Closed stkw0 closed 3 weeks ago

stkw0 commented 3 weeks ago

isounidecode don't have any new commits (nor releases) since 7 years ago. Also, seems that distros don't tend to package it (at least Gentoo, Debian and Fedora). Unidecode seems to be API compatible and work out of the box and is more active.

Taiko2k commented 3 weeks ago

I think this is good, but its not exactly the same API. unidecode() from isounidecode returns bytes where as unidecode returns str. So you just need to remove the .decode() from of any usages of unidecode().decode() in those two source files.

As a basic test just perform a global search in Tauon, if you can get any results to show then there should be no major problems.

Taiko2k commented 3 weeks ago

Also perhaps change "GPL-2.0" to "GPL-2.0+", to be clear we are using the "or later" clause.

stkw0 commented 3 weeks ago

Done, the search seems to work :)