Taiko2k / Tauon

The music player of today! :city_sunrise:
https://tauonmusicbox.rocks
GNU General Public License v3.0
1.81k stars 71 forks source link

A few issues with .cue files #486

Open awsms opened 3 years ago

awsms commented 3 years ago

The scrobbles count isn't kept in the database memory for each track (the play count seems also buggy, I've played these mixes a few times now). Another issue, the MPRIS metadatas don't seem to be updated on a track change.

Screenshot from 2021-03-18 21-01-03

Taiko2k commented 3 years ago

Did the missing scrobbles there actually get scrobbled? (I.e. to last FM)

EDIT: Actually what likely happend is tauon wasn't closed property / force closed

awsms commented 3 years ago

Yup, they were all finely scrobbled on last.fm. I'm 100% sure scrobbles aren't kept since they have never been kept for tracks+.cue (note these are MP3+cue, I don't know if it's relevant, haven't tried with FLAC+.cue yet).

Taiko2k commented 3 years ago

Is it possible Tauon was force closed when the counts were lost?

As for the MPRIS issue, I believe I've fixed that now in the new release.

awsms commented 3 years ago

If the play count is here but the scrobble count isn't (at all), that's because they don't seem to be kept.

Indeed, thanks for the MPRIS fix :)

I remember another issue I had, it's with cue+opus files. I don't know if it's a common issue since I don't believe a lot of users would play opus with .cue, but anyway. The last track of the cue will have its duration shown completely wrong, often a negative number. I could send you the files on Discord if you want to check it out. https://i.imgur.com/fsgqChP.png

Taiko2k commented 3 years ago

I remember another issue I had, it's with cue+opus files. I don't know if it's a common issue since I don't believe a lot of users would play opus with .cue, but anyway.

I remember this issue but I thought I had fixed it quite a while ago. Is that pic from an old database? Can you double check that freshly importing the folder again doesn't fix it? If it still does it then send the files to me on Discord.

If the play count is here but the scrobble count isn't (at all), that's because they don't seem to be kept.

Currently the play counts are written to disk periodically, but the scrobble-counts are only written on app exit. So if the app crashes or is killed, they will be lost, but should stay if the app if closed properly. If you're sure its not that then try double check.

As for making the scrobble-counts written periodically, its a little low priority for me to fix right now.