WIP: Add new Poster via QR code scan - Githubissues

TailorDev / pauling

:calling: Scientific posters on the go!

MIT License

7 stars 3 forks source link

WIP: Add new Poster via QR code scan #35

Closed jmaupetit closed 7 years ago

jmaupetit commented 7 years ago

[x] Integrate react-native-qrcode-scanner
[x] Add floating action buttons
[x] Add QR Scan view
[x] Scan Pauling QR Code
[x] Fetch Poster meta
[x] Create new Poster action to the main reducer
[x] Redirect to the new poster when created
[x] ~Fix spinner background when QR code has been scanned~ It seems to be a native base bug
[x] Implement Pauling url validity checking
[x] ~Add tests~ Postponed to a new PR for clarity purpose

willdurand commented 7 years ago

Just tried in real life, very nice!

Random comments:

I think the toast notification might not be useful anymore once we redirect the user to the poster.
Something like https://github.com/rt2zz/redux-persist would be really nice.
Can we get the abstract in the poster view too?
The saved date is not displayed for scanned posters
The QR code icon is always displayed once we click the + button, maybe it should be hidden on press/click/tap
This poster is having troubles when you zoom in/out

Anyway, cool stuff!

jmaupetit commented 7 years ago

Thanks for the review! I'll address required changes next week I guess.