Taimoor-Tariq / BetterDiscordStuff

My BetterDiscord Plugins and Themes

https://ko-fi.com/TaimoorTariq

GNU General Public License v2.0

19 stars 17 forks source link

Fixed Issue 39 #40

Closed MomoMiles closed 2 years ago

MomoMiles commented 2 years ago

39 Fixed with the issues suggested fix. Seems to work fine for me.

Malix-Labs commented 2 years ago

@MomoMiles change the title to "Fix #39" please 😊 (this will have the effect of bouding this PR to #39 and closing it in the meantime while logging it nicely in GitHub)

rexkix commented 2 years ago

It appears that the PR only changes one instance of this line at 819. As the comment above indicates, there is a second instance at 833. Changing the one line did not help, but changing both did.
The "{{ 2:00 pm }}" trick doesn't work with this fix. I have to use the menus.

Please understand that I am a novice at this stuff. Thanks. Did I do that right Malix?

Malix-Labs commented 2 years ago

Did I do that right @Malix-Off?

Lol, yes 👍 I found it important to let the PR author know what you've found 😄

Malix-Labs commented 2 years ago

I made a PR that correct that : https://github.com/MomoMiles/BetterDiscordStuff/pull/1

Malix-Labs commented 2 years ago

I made a PR that correct that : MomoMiles#1

Too late, i'm making a new one.

Malix-Labs commented 2 years ago

Too late, i'm making a new one.

44

Malix-Labs commented 2 years ago

@Taimoor-Tariq any reason for the close?

Taimoor-Tariq commented 2 years ago

Going to rewrite the plugin acording to the new BetterDiscord API

Malix-Labs commented 2 years ago

Comment Reply from @Taimoor-Tariq:

Going to rewrite the plugin acording to the new BetterDiscord API

Ok, nice. Could you create an issue about that so I can subscribe to its follow-up?