search

Taimoor-Tariq / BetterDiscordStuff

My BetterDiscord Plugins and Themes
https://ko-fi.com/TaimoorTariq
GNU General Public License v2.0
19 stars 17 forks source link

[ BUG | SendTimestamps ] Plugin could not be compiled (BD v1.7.0) #58

Open CyberedCake opened 2 years ago

CyberedCake commented 2 years ago

--> Pre note: I don't believe this is a copy of #51, lemme know if I'm wrong! <--

Issue Whenever I try to install the SendTimestamps plugin, it fails to compile in the new Better Discord v1.7.0.

TypeError: Cannot read property 'SingleSelect' of undefined
    at Object.get Dropdown [as Dropdown] (betterdiscord://plugins/0PluginLibrary.plugin.js:554:110)
    at Object.value (betterdiscord://plugins/0PluginLibrary.plugin.js:2649:24)
    at Object.get (betterdiscord://plugins/0PluginLibrary.plugin.js:2633:26)
    at plugin (betterdiscord://plugins/SendTimestamps.plugin.js:89:72)
    at eval (betterdiscord://plugins/SendTimestamps.plugin.js:887:22)
    at eval (betterdiscord://plugins/SendTimestamps.plugin.js:888:13)
    at eval (betterdiscord://plugins/SendTimestamps.plugin.js:889:3)
    at Object.requireAddon (<anonymous>:4:43438)
    at Object.loadAddon (<anonymous>:4:9197)
    at Object.loadAddon (<anonymous>:4:41165)
    at Object.reloadAddon (<anonymous>:4:10047)
    at AsyncFunction.<anonymous> (<anonymous>:4:7387)

I have already tried using the fix in #51, but it still failed to compile correctly!

Fusezion commented 2 years ago

@CyberedCake if you're unaware, a discord update ended up breaking betterdiscord and all corresponding plugins they'll need to update this plugin, however with the inactivity of development I doubt any time soon image

CyberedCake commented 2 years ago

@CyberedCake if you're unaware, a discord update ended up breaking betterdiscord and all corresponding plugins they'll need to update this plugin, however with the inactivity of development I doubt any time soon image

Yeah, I knew about that. Sucks too, because I really liked this plugin. I just can't bother to learn JS and the BdApi to fix this. Hopefully another plugin will replace this awesome one.

Fusezion commented 2 years ago

@CyberedCake if you're unaware, a discord update ended up breaking betterdiscord and all corresponding plugins they'll need to update this plugin, however with the inactivity of development I doubt any time soon image

Yeah, I knew about that. Sucks too, because I really liked this plugin. I just can't bother to learn JS and the BdApi to fix this. Hopefully another plugin will replace this awesome one.

There's most likely a few better(bad wording) discord devs that would remake this maybe not as custom

Sebas-Re commented 2 years ago

:(

Taimoor-Tariq commented 2 years ago

Hey guys, Sorry for being inactive for too long. I had a lot going on so I was not able to fix bugs. As you may know that the recent Discord update broke a lot of the plugins. I will attempt to fix my plugins once I figure out what the broken changes are 💛.

ArcturusLight1 commented 2 years ago

Just installed better discord, this is the first plugin i went for. Best wishes to the dev, i can provide only moral support. This is the cutest "you tried running me directly" code that i've ever seen.

CyberedCake commented 2 years ago

Hey guys, Sorry for being inactive for too long. I had a lot going on so I was not able to fix bugs. As you may know that the recent Discord update broke a lot of the plugins. I will attempt to fix my plugins once I figure out what the broken changes are 💛.

Hey! It's all right. I understand the absence part. Also, I feel like you should know that you can take your time, we can wait if absolutely necessary. SendTimestamps was just a nice QoL thing and, while I would love it to be back, you take all the time you need!

ElProfessorFR commented 2 years ago

A lot of plugin work now...

Canada-LaVearn commented 1 year ago

This issue still persists, hoping for a fix soon!

Taimoor-Tariq commented 1 year ago

Hey guys,

Huge announcement. I will be discontinuing this plugin in compliance with Discord. Discord is adding the plugins functionality to their main client.

Thank you to everyone who used my plugin ❤️.

Taimoor-Tariq commented 1 year ago

Screenshots of what Discord is adding

208880731-3310633d-f806-4bea-bd5f-f061b86c4816 208880618-db42dc3c-fb27-447e-8f5f-9804f5a4728c

aaronliu0130 commented 1 year ago

How is this feature triggered? Is it only in canary/ptb?

rexkix commented 1 year ago

Hey guys,

Huge announcement. I will be discontinuing this plugin in compliance with Discord. Discord is adding the plugins functionality to their main client.

Thank you to everyone who used my plugin ❤️.

EDIT: I see now that Discord is adding something that fills the bill. Never mind.

~~Hello Taimoor. If I can find somebody who can take over the plugin, would that be acceptable to you somehow. How should they reach out to you? I do have somebody in mind. I'm good friends with samfundev who fixed the ChannelTabs plugin.

Please advise. Thanks for an amazing plugin and good luck to you.~~

CyberedCake commented 1 year ago

Screenshots of what Discord is adding

208880731-3310633d-f806-4bea-bd5f-f061b86c4816 208880618-db42dc3c-fb27-447e-8f5f-9804f5a4728c

Looks pretty awesome! Thank you for the work you did on the plugin before Discord adds their own! Really appreciate developers like you who dedicate time to stuff like this, even if it ends up getting added to the client (which should be considered a win!).

Masono03 commented 1 year ago

Screenshots of what Discord is adding

208880731-3310633d-f806-4bea-bd5f-f061b86c4816 208880618-db42dc3c-fb27-447e-8f5f-9804f5a4728c

oh? how do u acticate that :0 cant find the entry for it in experiments

louis1706 commented 1 year ago

i would like to know how use this ?

Violet-Scarelli commented 1 year ago

I also wanna know... how do you get this feature?

Sebas-Re commented 1 year ago

F?

Tyrand commented 1 year ago

The Discord implantation is still not released.

aurkaxi commented 1 year ago

F

ArcturusLight1 commented 1 year ago

What does "in compliance with Discord" mean?

aaronliu0130 commented 1 year ago

@Taimoor-Tariq when will this discord feature come?

Soulivan71 commented 1 year ago

The discord, feature never going to be release .. its in dev since 12/2022

Taimoor-Tariq commented 1 year ago

I have decided to work on the plugin again since I am starting to get more free time. Expect updates within the next few weeks.

Thank you all for all your patience ❤️

Soulivan71 commented 1 year ago

Okay thx !

AnonymousX86 commented 1 year ago

Error still exists:

TypeError: Cannot read properties of undefined (reading 'ComponentDispatch')
    at plugin (betterdiscord://plugins/SendTimestamps.plugin.js:91:91)
    at eval (betterdiscord://plugins/SendTimestamps.plugin.js:887:22)
    at eval (betterdiscord://plugins/SendTimestamps.plugin.js:888:13)
    at eval (betterdiscord://plugins/SendTimestamps.plugin.js:889:3)
    at M.requireAddon (betterdiscord/renderer.js:4:35818)
    at M.loadAddon (betterdiscord/renderer.js:4:8323)
    at M.loadAddon (betterdiscord/renderer.js:4:33490)
    at M.loadAllAddons (betterdiscord/renderer.js:4:10795)
    at M.initialize (betterdiscord/renderer.js:4:5219)
    at M.initialize (betterdiscord/renderer.js:4:32689)
    at Object.startup (betterdiscord/renderer.js:4:359757)

Friendly reminder. I have an idea. Maybe Instead of sending timestamp as plain text, send built-in timestamps? Currently I'm using this: https://r.3v.fi/discord-timestamps/, but it would be great to be able to do this within client and don't switch to the website.

aaronliu0130 commented 1 year ago

The plug-in is supposed to send built-in time stamps, I don’t know why you think it sends as plain text. HammerTime is a better web GUI for these.

Sebas-Re commented 1 year ago

Just use Vencord, people, it has most BD plugins and works better in terms of performance

aaronliu0130 commented 1 year ago

Excuse me, Replugged is way better. Bundling plug-ins is bloat and having most BD plugins is a weakness because of DevilBro. Replugged also has no dependency hell and has mature theme and plug-in packaging. No memory issues either.

Sebas-Re commented 1 year ago

Or Reppluged, yeah! Whichever works best, just trying to enfasize there's always alternatives for this issue, especially if you only use the timestamp plugin (Although I think replugged didn't have that one? Don't remember)

aaronliu0130 commented 1 year ago

Hmm, I’m surprised that it doesn’t.

QuentinMcCarthy commented 1 year ago

Hey guys,

Huge announcement. I will be discontinuing this plugin in compliance with Discord. Discord is adding the plugins functionality to their main client.

Thank you to everyone who used my plugin ❤️.

wdym by in compliance? BD is in itself non-compliant with Discord. I see no reason not to continue with this plugin until it becomes redundant, because as it is there is no way to send timestamps in Discord. This plugin is the only way and it's inoperable, plus we don't know WHEN Discord will add their own feature for it.

aaronliu0130 commented 1 year ago

@QuentinMcCarthy Firstly, see their reply on August 18. Secondly, it’s not like violating Discord, it’s that at the time they thought this plugin was going to be redundant soon.

jacobmix commented 11 months ago

Since Discord is clearly not adding this any time soon, it'd be nice to at least have a plugin that does the job. Not sure Discord ever officially mention a release date. All i find is a reddit post: https://old.reddit.com/r/discordapp/comments/zrgfku/discord_is_adding_a_ui_for_editing_timestamps/ Hope the plugin returns.

QuentinMcCarthy commented 11 months ago

@aaronliu0130 My bad I didn't see their response saying they were working on it again.

QuentinMcCarthy commented 9 months ago

Temporary fix here: https://github.com/Taimoor-Tariq/BetterDiscordStuff/issues/63#issuecomment-1926223637