Taitava / obsidian-shellcommands

Execute system commands via hotkeys or command palette in Obsidian (https://obsidian.md). Some automated events are also supported, and execution via URI links.
GNU General Public License v3.0
351 stars 11 forks source link

When an incompatible settings file is encountered, the plugin is unable to disable itself #113

Closed Taitava closed 2 years ago

Taitava commented 2 years ago

0.7.0 brought a feature that disables the plugin if it encounters a settings file that is too new for the plugin to understand. I just found out that the disabling does not work. The plugin gets disabled in the community plugin settings, but it actually continues working, because the plugin does not stop loading after noticing the version problem. When I created the feature, I thought it's enough to just call this.app.plugins.disablePlugin() to also stop further execution of the plugin's code, but I was wrong.

I'll need to add a manual break to the code execution.

Disabling the plugin in case of incompatible settings file version is needed in order to avoid the plugin screwing things up if it would try to interpret the settings file in an incorrect way.

Taitava commented 2 years ago

Fixed.