search

Taitava / obsidian-shellcommands

Execute system commands via hotkeys or command palette in Obsidian (https://obsidian.md). Some automated events are also supported, and execution via URI links.
GNU General Public License v3.0
351 stars 11 forks source link

#114 caret position variable #118

Closed vrajur closed 2 years ago

vrajur commented 2 years ago

Description

Adds a new variable caret_position to the list of supported variables for the shell command plugin. This PR is current with development in the 0.8.0 branch.

Change Type: New Feature

See related discussion in #114

Taitava commented 2 years ago

I created an AUTHORS.md file in the 0.8.0 branch

https://github.com/Taitava/obsidian-shellcommands/blob/0.8.0/AUTHORS.md

If you want, you can add your information there. Just include the commit in this same PR. 🙂

vrajur commented 2 years ago

Thanks for the review! I updated all your suggestions, updated the AUTHORS.md file and squashed the changes into a single commit (formatted as you specified). Let me know if there's anything else.

I also opened an associated PR in the docs repository with a very simple example for you to take a look at as well.

Thanks!

Taitava commented 2 years ago

Changed the license from MIT to GPL-3.0

Hi @vrajur ! 🙂

I've decided to change the license of this project to GPL. At the same time, I added copyright headers to all source code files, including the one you made. Can you check the copyright statement here and tell me if it's okay to you: https://github.com/Taitava/obsidian-shellcommands/blob/5e155e960cea25717d5575b4523b19cec3f9f3c2/src/variables/Variable_CaretPosition.ts

The updated version of Variable_CaretPosition.ts that contains the copyright statement is not yet in the main branch, it's still in #199-change-license-to-GPL, but will be merged to main when I release 0.12.0.

Thank you again for your great contribution! 😎

Edit: More information about the license change: https://github.com/Taitava/obsidian-shellcommands/discussions/192