search

Taitava / obsidian-shellcommands

Execute system commands via hotkeys or command palette in Obsidian (https://obsidian.md). Some automated events are also supported, and execution via URI links.
GNU General Public License v3.0
351 stars 11 forks source link

Output to status bar: Don't ignore empty output #124

Closed Taitava closed 2 years ago

Taitava commented 2 years ago

Currently, if a shell command outputs nothing, and if status bar already contains content from a previous execution, the old content stays in the status bar.

Empty output content should make the status bar content empty.

FelipeRearden commented 2 years ago

Currently, if a shell command outputs nothing, and if status bar already contains content from a previous execution, the old content stays in the status bar.

Empty output content should make the status bar content empty.

@Taitava please take a look at this #127 before making changes in the content of the status bar 🙏 !!!!!!

Thanks !!!

Taitava commented 2 years ago

Ok, as we've had some discussion in #127, I think #127 will probably be so different that the change mentioned in this issue won't affect it at all, I think.

@FelipeRearden what do you think about in general for this status bar change, is it ok that empty output to status bar will clear it? Or do you see some problems here? 🙂 I can also move this from 0.9.0 to 0.10.0 so that this can be first tested in a beta version (I won't probably make a beta for 0.9.0, but 0.10.0 will have one).

FelipeRearden commented 2 years ago

Ok, as we've had some discussion in #127, I think #127 will probably be so different that the change mentioned in this issue won't affect it at all, I think.

100% agree!

@FelipeRearden what do you think about in general for this status bar change, is it ok that empty output to status bar will clear it? Or do you see some problems here? 🙂 I can also move this from 0.9.0 to 0.10.0 so that this can be first tested in a beta version (I won't probably make a beta for 0.9.0, but 0.10.0 will have one).

I don't see any problem @Taitava ! My only concern was about my FR on #127. I was afraid that you made a change today that could make you rewrite/redo in the future due to #127. But it's all clear now and I don't see ant issue about clear the status bar :)

Taitava commented 2 years ago

Done. 🙂

Taitava commented 2 years ago

Released.