search

Taitava / obsidian-shellcommands

Execute system commands via hotkeys or command palette in Obsidian (https://obsidian.md). Some automated events are also supported, and execution via URI links.
GNU General Public License v3.0
351 stars 11 forks source link

Add (broken) notional impl of selection-as-stdin #128

Closed dathanb closed 1 year ago

Taitava commented 2 years ago

I'm not currently working on this. but I just wanted add a remark here that like was discussed earlier here, this PR is more of an example on how to implement stdin support, not something to be actually merged. So I'll convert this PR to a draft now.

Thank you @dathanb again for this example, I'll use it when I have time to look into this stdin feature (#89). It's also good for #64.

Taitava commented 1 year ago

Just a short mention here, too. I've taken some example from this PR when implementing #64 / #275, and will take more example when implementing #89 / #283. I will probably not end up merging this particular PR, but just wanted to say that it will be utilized. 👍

I'll close this PR after #283 is released.

Taitava commented 1 year ago

I'm closing this PR now, as #283 / 0.18.0 was released a couple of days ago. This code was not used, but in case any problems occur with #283, I might still come back here to check if there's something here that I could still learn from. 🙂