Taitava / obsidian-shellcommands

Execute system commands via hotkeys or command palette in Obsidian (https://obsidian.md). Some automated events are also supported, and execution via URI links.
GNU General Public License v3.0
351 stars 11 forks source link

Fix: Autocomplete suggests variables when typing right after a closing }} pair #129

Closed Taitava closed 2 years ago

Taitava commented 2 years ago

kuva

When writing just after a closing }} pair (without a space in-between), the autocomplete menu thinks that a user is typing a variable name, although in reality the typing happens outside of any variable structure. There is a check for }} in place, but it happens slightly too late on line 263:

https://github.com/Taitava/obsidian-shellcommands/blob/d64d44246ab0d17ddcab4255a8d7a49aa7cea048/src/settings/setting_elements/Autocomplete.ts#L251-L267

So, this should... https://github.com/Taitava/obsidian-shellcommands/blob/d64d44246ab0d17ddcab4255a8d7a49aa7cea048/src/settings/setting_elements/Autocomplete.ts#L263-L267

...appear before this one: https://github.com/Taitava/obsidian-shellcommands/blob/d64d44246ab0d17ddcab4255a8d7a49aa7cea048/src/settings/setting_elements/Autocomplete.ts#L251-L262

For the example in the screenshot, no autocomplete menu should appear.