Hotkeys for output channel: Ask after execution

Taitava / obsidian-shellcommands

Execute system commands via hotkeys or command palette in Obsidian (https://obsidian.md). Some automated events are also supported, and execution via URI links.

GNU General Public License v3.0

351 stars 11 forks source link

Hotkeys for output channel: Ask after execution #145

Closed Taitava closed 2 years ago

Taitava commented 2 years ago

Discussed in https://github.com/Taitava/obsidian-shellcommands/discussions/138

I decided to do these improvements later, not in 0.10.0.

[x] Add hotkeys Ctrl/Cmd + ~~1, 2, 3 etc...~~ a letter to use different output channel buttons. Read more: https://github.com/Taitava/obsidian-shellcommands/discussions/139
[x] Add a Shift modifier to the abovementioned ~~number~~ letter hotkeys to close the modal after using an output channel.
[x] Make Ctrl/Cmd + clicking the buttons also close the modal.
[x] Change the hotkeys from numbers to letters: https://github.com/Taitava/obsidian-shellcommands/discussions/139#discussioncomment-2302643
[x] Change the tooltip: https://github.com/Taitava/obsidian-shellcommands/discussions/139#discussioncomment-2301211

Taitava commented 2 years ago

@FelipeRearden I'll need your help testing this when a beta for 0.12.0 comes out (not yet). The thing is that I know it works with the Ctrl key, but I'm not certain if my code handles Mac's Cmd key too. It will still take time until 0.12.0 is ready for a beta test, as #37 still takes a long time. I just wanted to write this now so that I don't forget when the beta comes out.

FelipeRearden commented 2 years ago

@FelipeRearden I'll need your help testing this when a beta for 0.12.0 comes out (not yet). The thing is that I know it works with the Ctrl key, but I'm not certain if my code handles Mac's Cmd key too. It will still take time until 0.12.0 is ready for a beta test, as #37 still takes a long time. I just wanted to write this now so that I don't forget when the beta comes out.

Sure @Taitava !!!!!!!

You can count on me :) :) :)

Just one comment: If were easier for you we could make this hotkey only available with CRTL instead of CMD. Since MacOS does not have any OS hotkey applied to CRTL+1...9

Have a great day!!!!!

Taitava commented 2 years ago

If were easier for you we could make this hotkey only available with CRTL instead of CMD. Since MacOS does not have any OS hotkey applied to CRTL+1...9

I don't even know how it goes now on macOS. Ctrl/Cmd + click on a button uses a bit different logic than the Ctrl/Cmd + Shift + number feature. So to be honest, even though I have written the key Cmd to the tooltips, I'm not sure if the code actually uses Cmd or Ctrl on macOS. But you can test later how it happens to be, and I can change it if it's wrong.

I'm not familiar with macOS, but I'm familiar with the trait in Obsidian forums, that every time when a hotkey involving Ctrl is mentioned, it's paired with Cmd on macOS (e.g. Ctrl/Cmd + N), not with macOS's Ctrl. So I'd like it to be Cmd on macOS, instead of Ctrl, just for the sake of consistency within the ecosystem of Obsidian.

Have a nice day, too! 🙂

Taitava commented 2 years ago

Done. Will be released in 0.12.0. See a screenshot here: https://github.com/Taitava/obsidian-shellcommands/discussions/139#discussioncomment-2538342

Taitava commented 2 years ago

@FelipeRearden The beta is now available, so you can test the hotkeys whenever you have time 🙂:

@FelipeRearden I'll need your help testing this when a beta for 0.12.0 comes out (not yet). The thing is that I know it works with the Ctrl key, but I'm not certain if my code handles Mac's Cmd key too. It will still take time until 0.12.0 is ready for a beta test, as #37 still takes a long time. I just wanted to write this now so that I don't forget when the beta comes out.

Taitava commented 2 years ago

Released.