search

Taitava / silverstripe-slickcarousel

A Slick carousel wrapper for SilverStripe. See: http://kenwheeler.github.io/slick/
MIT License
1 stars 1 forks source link

MINOR: changing injected sort column to be an string instead of an array #10

Closed spekulatius closed 4 years ago

spekulatius commented 5 years ago

Solves #9 (for me). To be confirmed, if this does the same for you @Taitava

Taitava commented 4 years ago

Hi Peter,

thanks for the PR, the fix seems OK but it seems your editor has changed the indentations of some empty lines. Can you edit this PR so that it doesn't change the empty lines, please?

spekulatius commented 4 years ago

Hey @Taitava

I've adjusted the empty lines. It was trailing spaces which have been removed automatically. Have a look please.

Cheers, Peter

Taitava commented 4 years ago

@spekulatius Thank you very much! :)

spekulatius commented 4 years ago

No problem :) Thanks for taking the time to check it and merge it :)

On Mon, 30 Sep 2019 at 13:05, Jarkko Linnanvirta notifications@github.com wrote:

@spekulatius https://github.com/spekulatius Thank you very much! :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Taitava/silverstripe-slickcarousel/pull/10?email_source=notifications&email_token=ACAK7M6INQN4ZLSYVEP7MGLQMHMQ7A5CNFSM4IDHV3ZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD75IZGQ#issuecomment-536513690, or mute the thread https://github.com/notifications/unsubscribe-auth/ACAK7M6637YBFRH5CGMMZGDQMHMQ7ANCNFSM4IDHV3ZA .