search

Taitava / silverstripe-slickcarousel

A Slick carousel wrapper for SilverStripe. See: http://kenwheeler.github.io/slick/
MIT License
1 stars 1 forks source link

Dynamically scale with window resize #4

Closed hp7 closed 7 years ago

hp7 commented 7 years ago

Is there anyway to set the image to dynamically scale, when the browser window is resized? The normal way setting width=100% height=auto does not work since your code is taking the image width and setting a fixed width to the slide container. Setting responsive break points is not good enough when using elastic designs. I noticed the slick demo site actually does do what I am asking about. Thanks for the great extension, any input would be great

Taitava commented 7 years ago

Thanks for your question! :)

I think the module should not set any fixed width or height unless you have explicitly configured it to do so. This default configuration should prevent the module from defining a fixed width:

Carousel:
  use_image_dimensions: false

If you already have set that option to false and it still defines fixed dimensions for the containers, it must be a bug. Please let me know if there's a bug and I will fix it.

Whether it's a bug or not, another way that might help a little bit - although this is not so convenient - is that you could copy CarouselSlide.ss to themes/*your-theme-name*/templates and modify it so that it doesn't use $StyleAttribute to define inline CSS styles for the container.

Please remember to run ?flush=all after any change to the configuration and/or after creating a new template file.

Does any of this help you?

hp7 commented 7 years ago

I had a typo in the following. Thanks! Carousel: use_image_dimensions: false