search

Taiters / chip8

A Chip8 emulator which runs in the browser along with tools to view the registers and instructions
https://chip8.dotslashdan.com
MIT License
5 stars 4 forks source link

Finish writing unit tests for Chip8 instructions #10

Closed Taiters closed 5 years ago

Taiters commented 6 years ago

It would be good to finish the unit tests for the instructions. These tests have been started, so existing tests can be used as a guide.

The Chip8 instructions can be viewed here

The current tests can be viewed here and the instruction implementations are here.

As far as unit tests go these should be pretty straightforward, as we can just pass in a state, and assert on the values of the returned state.

Happy to answer any questions!

nimvb commented 5 years ago

@Taiters Could you please check the pull request that I submitted for the issue?