search

TaitoUnited / react-components-kit

A collection of reusable and themable React UI components built with styled-components
https://taitounited.github.io/react-components-kit/
14 stars 2 forks source link

Consistent button border size #2

Closed jesstelford closed 6 years ago

jesstelford commented 6 years ago

Adjacent buttons with/without the outline prop will now have the same height.

Old: different-height

New: same-height

New with hover: same-height-hovered

jesstelford commented 6 years ago

Hmm, this has negative effects on non-flat buttons:

non-flat-border

Maybe we should add an extra pixel of padding? Or remove a pixel of padding from the outline'd button?

Temzasse commented 6 years ago

Thank you for the contribution!

I'll investigate this and your other pr together and I'll try to find a satisfying solution 🙂

Temzasse commented 6 years ago

Now the borders should be consistent :)

I had to implement this a bit differently (and I'm not that great with Github) so I'm not merging this pr since I fix button things here: fa0f027fcd0c414818aef63c6141c2c82be688cb.