search

TaitoUnited / react-components-kit

A collection of reusable and themable React UI components built with styled-components
https://taitounited.github.io/react-components-kit/
14 stars 2 forks source link

Ensure <button> children are semantically correct #5

Closed jesstelford closed 6 years ago

jesstelford commented 6 years ago

<div> shouldn't live inside a <button>

Temzasse commented 6 years ago

Hi again! ✋

I fixed this in this commit (faa9f3f3dda1c341b44b4379a7805ba1fca062bb) 😃

I also realized that I should make it more clear that in order to successfully merge these PRs the commits have to be in a certain form so that Travis and semantic-release knows how to bump up the version number.

So, after you have made some changes and staged them you can runnpm run commit that will ensure the correct commit message format (it uses commitizen). You can also just write the commit message in the right format yourself if you want.