Closed dartanian300 closed 1 year ago
Hey :)
You can click the profil in the top right to get the navigation, it doubles down as a hamburger menu :D Yeah I am not completely happy with the logo. (Just added it the last update, because I wanted the site to be easily recognizable)
Took a look at the mobile modal issue and I think I see what the issue is. On mobile, collectionOnly
is set to false
while it's set to true
on desktop. When it's false
, the app does not attempt to open the modal:
full-card.component.ts:
addCardToDeck() {
if (this.collectionOnly) {
this.viewCard.emit(this.card);
return;
}
this.store.dispatch(addCardToDeck({ addCardToDeck: this.card.id }));
}
It seems this is due to differences in how the 2 views are rendered.
collection-page.component.ts:
<div class="bg-gradient-to-b from-[#17212f] to-[#08528d] ">
<div class="hidden md:block">
<digimon-collection-view
[collectionOnly]="true"
[deckView]="false"
></digimon-collection-view>
</div>
<div class="md:hidden">
<digimon-filter-and-search></digimon-filter-and-search>
<digimon-card-list [showCount]="32"></digimon-card-list>
</div>
</div>
card-list.component.ts:
...
<digimon-full-card
*ngFor="let card of cardsToShow"
(viewCard)="viewCard($event)"
[card]="card"
[collectionMode]="(collectionMode$ | async) ?? false"
[count]="getCount(card.id)"
[deckView]="true"
[deckBuilder]="true"
class="flex-[1 1 25%] max-w-[25%] scale-95 transition"
>
</digimon-full-card>
...
Looks like it's defaulted to false. At least that's what I'm seeing with my limited Angular experience.
The collection only attribute is used when one should be able to open the modal with a simple click or touch. Because that should add the card to the deck. What should show the Modal either way is a long click or double click :)
Ah, I see. Long/double clicks don't seem to work either.
This issue actually also exists on desktop. If you drag in the browser so that it becomes the mobile view you can't open the modal via regular click/tap, long click/tap or double click/tap.
Most Issues should now be with old phones and iPhones. Otherwise most stuff should work, so I am gonna open a new Ticket.
On mobile devices (specifically Safari on iOS) there are a few issues:
The following aren't issues specifically, but some UI/UX feedback:
I am a web developer so feel free to ask additional technical questions if you need clarification.