Takaaki-Saeki / ssl_speech_restoration

SelfRemaster: SSL Speech Restoration
MIT License
84 stars 8 forks source link

No versions in requirements.txt #6

Closed chrisbaume closed 2 years ago

chrisbaume commented 2 years ago

Hello. Thanks for publishing your code and checkpoints 😃

I've come across the following error

dataset.py:145: VisibleDeprecationWarning: Creating an ndarray from ragged nested sequences (which is a list-or-tuple of lists-or-tuples-or ndarrays with different lengths or shapes) is deprecated. If you meant to do this, you must specify 'dtype=object' when creating the ndarray.

Although this warning disappears when you add dtype=object, I came across another problem later on and was unable to get the system running.

My suggestion is to add version numbers for each dependency in requirements.txt. That way, we can know which versions of each library form a working solution, and the code will continue to work in the future after libraries have changed.

Takaaki-Saeki commented 2 years ago

Sorry for the delay and thank you so much for the suggestion. I have added the version numbers. If you have any further problems, please let me know.