Daemonize timer threads in ReadingThread, fixes #140

TakahikoKawasaki / nv-websocket-client

High-quality WebSocket client implementation in Java.

Apache License 2.0

2.03k stars 292 forks source link

Daemonize timer threads in ReadingThread, fixes #140 #169

Closed alandipert closed 6 years ago

alandipert commented 6 years ago

I don't have a full understanding of ReadingThread or why the Timer's task isn't completing, but daemonizing the timer's thread fixes the hang for me.

MinnDevelopment commented 6 years ago

This doesn't really fix it as the thread still exists but doesn't prevent the JVM from shutting down. It would be better for the timer to be stopped for proper cleanup.

alandipert commented 6 years ago

Closing because it's not a real fix. For now I'm working around it by calling System.exit(0) in my application until we can figure it out.