search

TakahikoKawasaki / nv-websocket-client

High-quality WebSocket client implementation in Java.
Apache License 2.0
2.03k stars 292 forks source link

New version 2.11 doesn't send PONG #223

Closed brnostone closed 3 years ago

brnostone commented 3 years ago

After a while debugging my app, I checked version 2.11 with some bug that is not arriving at my PONG frame server, this bug only happens in this version.

TakahikoKawasaki commented 3 years ago

The only difference between 2.11 and the previous version was PR #217. Any thoughts, @nosnilmot ?

TakahikoKawasaki commented 3 years ago

Is PR #222 related, @nosnilmot ? Anyway, it seems that a new version of nv-websocket-client with PR #222 should be released...

TakahikoKawasaki commented 3 years ago

@brnostone I released nv-websocket-client 2.12 including #PR #222. Could you try the new version?

nosnilmot commented 3 years ago

Pong frames could be impacted by the empty payload bug in PR 217/fixed by PR 222 if they are in response to a Ping with empty/no payload, or if they are unsolicited periodic pongs.

brnostone commented 3 years ago

Now it's working, thanks