search

TakataSanshiro / Chocolatey-Packages

Some packages that can be installed via chocolatey.org
MIT License
15 stars 29 forks source link

update github-desktop package to 1.5.0 #19

Closed shiftkey closed 5 years ago

shiftkey commented 5 years ago

I think that's all the necessary changes - let me know if I've missed anything

TakataSanshiro commented 5 years ago

@shiftkey Thanks. But, the title needs one.

shiftkey commented 5 years ago

But, the title needs one.

@TakataSanshiro not sure I understand this bit - can you elaborate in case I need to contribute a future PR?

TakataSanshiro commented 5 years ago

https://chocolatey.org/docs/create-packages#naming-your-package

The title of your package ( tag in the nuspec) should be the same as the name of the application. Follow the official spelling, use upper and lower case and don't forget the spaces. </p> </blockquote> <p><a href="https://chocolatey.org/packages/github-desktop/0.5.8">https://chocolatey.org/packages/github-desktop/0.5.8</a></p> <blockquote> <p>flcdrg (reviewer) on 28 May 2017 05:45:15 +00:00: I think you should mention in the description that this essentially replaces <a href="https://chocolatey.org/packages/GitHub">https://chocolatey.org/packages/GitHub</a> but is a different application.</p> </blockquote> <p>There is "The new native" title on <a href="https://desktop.github.com/">https://desktop.github.com/</a> It's chocolatey community's decision, not only me.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/shiftkey"><img src="https://avatars.githubusercontent.com/u/359239?v=4" />shiftkey</a> commented <strong> 5 years ago</strong> </div> <div class="markdown-body"> <blockquote> <p>There is "The new native" title on <a href="https://desktop.github.com/">https://desktop.github.com/</a> It's chocolatey community's decision, not only me.</p> </blockquote> <p>That's part of the marketing website, and isn't intended to be part of the package manager search. Homebrew has this right: <a href="https://github.com/Homebrew/homebrew-cask/blob/c5d9b8a3a1ce448a763ba59d76ec1b6f6449823d/Casks/github.rb#L8">https://github.com/Homebrew/homebrew-cask/blob/c5d9b8a3a1ce448a763ba59d76ec1b6f6449823d/Casks/github.rb#L8</a></p> <p>The name of the program when installed is just <code>GitHub Desktop</code> and the <code><title></code> attribute on the marketing site is <code>GitHub Desktop | Simple collaboration from your desktop</code>.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/TakataSanshiro"><img src="https://avatars.githubusercontent.com/u/25909315?v=4" />TakataSanshiro</a> commented <strong> 5 years ago</strong> </div> <div class="markdown-body"> <p>OK. Homebrew is good. Thanks. <a href="https://github.com/TakataSanshiro/Chocolatey-Packages/commit/6d25c3c24fd8edc9dbd113e1f3d88a9a2269915b#diff-0ec53d95ce654bf2c938672412de2d1d">https://github.com/TakataSanshiro/Chocolatey-Packages/commit/6d25c3c24fd8edc9dbd113e1f3d88a9a2269915b#diff-0ec53d95ce654bf2c938672412de2d1d</a></p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>