search

TakataSanshiro / Chocolatey-Packages

Some packages that can be installed via chocolatey.org
MIT License
15 stars 29 forks source link

Fix icon for GitHub Desktop #20

Closed FranklinYu closed 5 years ago

FranklinYu commented 5 years ago

I figured that if you don’t change the URL, the Chocolatey website won’t update the icon. The RawGit CDN has a strong caching policy that only caches first version of that URL, so having SHA-1 in the URL helps.

In addition RawGit is deprecated. GitHub now delivers correct header for PNG and JPEG so no need to find anything else. (But for SVG we still need jsDelivr.)

TakataSanshiro commented 5 years ago

OK. But, https://chocolatey.org/docs/create-packages#package-icon-guidelines

Package icon guidelines: Avoid using GitHub raw links (https://raw.githubusercontent.com/...). They are not intended to be used as CDN.

"RawGit is deprecated." Yes, please wait until chocolatey community decision.

FranklinYu commented 5 years ago

I changed the URL to use jsDelivr, a CDN website.

About whether to enforce CDN for package icon, I had a conversation with several Chocolatey member on Gitter. They claim that it can be several downloads a day, which is not persuasive at all (large website like GitHub is able to take a request per-second without CDN). Anyway I understand that you want to follow their guide.

FranklinYu commented 5 years ago

Any update? jsDelivr is already being used by several packages it should be OK.

TakataSanshiro commented 5 years ago

@FranklinYu Thanks.