search

TakataSanshiro / Chocolatey-Packages

Some packages that can be installed via chocolatey.org
MIT License
15 stars 29 forks source link

Update chocolateyinstall.ps1 #76

Closed chtof closed 3 years ago

chtof commented 3 years ago

Github Desktop installer provides now 2 installer, one for 32 bits system GitHubDesktopSetup.exe and another for 64 bits system GitHubDesktopSetup-x64.exe So, file = (Get-Childitem -Path $toolsDir -Filter "*.exe").fullname does not longer work as it returns now 2 files and "file" argument expects only one.

My suggestion here is to add the filenames for 32 and 64 bits system: file = "$toolsDir\GitHubDesktopSetup.exe" file64 = "$toolsDir\GitHubDesktopSetup-x64.exe"

It allows me to upgrade Github Desktop on my Windows 10 64 bits.

chtof commented 3 years ago

Well, I close this pull request as the update works properly on another computer. So, I think "GitHubDesktopSetup.exe" come from a previous version. So probably users impacted by this isue should remove this old GitHubDesktopSetup.exe in C:\ProgramData\chocolatey\lib\github-desktop.2.8.2\tools (to be tested). Another way should to change chocolateyinstall.ps1 to remove GitHubDesktopSetup.exe at the beginning of the script.