TakataSanshiro / Chocolatey-Packages

Some packages that can be installed via chocolatey.org
MIT License
15 stars 29 forks source link

protonvpn significantly out of date #95

Closed superusercode closed 1 year ago

superusercode commented 1 year ago

current major version is now 3.x https://github.com/ProtonVPN/win-app

TakataSanshiro commented 1 year ago

@superusercode Thanks for your inform. I'll look at it.

TakataSanshiro commented 1 year ago

I cannot install the version 3.0.5 on Windows 10. It might have a compatibility issue. We need to wait some weeks for more information.

This application does not support your Windows version. You will be redirected to a download page with an application suitable for your Windows version.

vairag22 commented 1 year ago

Any updates?

I tried installing v3.0.5 (downloaded from their GitHub page) on my machine and it installs without any issues. I use Windows 10 IoT Enterprise LTSC v21H2.

TakataSanshiro commented 1 year ago

@vairag22 Any problems with upgrading from the previous version 2 installed?

vairag22 commented 1 year ago

Did a clean install. I choco uninstalled v2.4.2 then manually installed v3.0.5.

vairag22 commented 1 year ago

For the sake of testing, I am going to:

Let's see how it goes.

vairag22 commented 1 year ago

I didn't not encounter any issues, everything went well.

Would like to mention 2 things:

TakataSanshiro commented 1 year ago

@vairag22 Thanks for your testing. Your mention is very helpful. I didn't realize that behaviour of v2.4.2.

vairag22 commented 1 year ago

@vairag22 Thanks for your testing.

You're welcome. It was the least I could do to help.

There are some issues with the current update:

vairag22 commented 1 year ago

This is from ProtonVPN website:

Using Windows 7, Windows 8/8.1 or a 32-bit version of Windows? Download Proton VPN here.

Clicking "here" will download v2.4.2.

It's too early to jump on conclusions, scrutiny is needed. In the mean time, can something be done to only install OS Architecture specific version of dependencies?

In any case, v3.0.7 was uploaded to GitHub just a few hours ago. It's a minor update so dependency changes are unlikely. Will test and let you know.

TakataSanshiro commented 1 year ago

End of support for Windows 7 and Windows 8 officially. I misunderstood that too, 32-bit Windows 10. I should've been investigating more carefully. I'll make a beta version for testing purposes for the next major update.

TakataSanshiro commented 1 year ago

The v2.4.2 unlisted due to it's not open source.

vairag22 commented 1 year ago

I'll make a beta version for testing purposes for the next major update.

That would be nice.

The v2.4.2 unlisted due to it's not open source.

Yes, I am aware of that. I was just asking if they have ended support for x86 from v3.x.x onwards.

ProtonVPN is very specific on what dependency it uses, and please update it to v3.0.7

Sorry I had exams last week and this week as well so I couldn't find the time to test the package. Hopefully I'll give you an update by this weekend.

I should've been investigating more carefully.

No worries, I'm happy to help you. You're are maintaining packages for free at expense of your own time. Thank you :)

vairag22 commented 1 year ago

🚨 Dependency Changes for ProtonVPN v3.0.7 🚨

Dependency on ASP.NET Core and DotNet Desktop Runtime have been removed. Only .Net Framework is required.

test

vairag22 commented 1 year ago

I've made necessary changes and opened a pull request #97. Please review. Mark this issue as closed after changes have been merged, as protonvpn will no longer be out-of-date.

TakataSanshiro commented 1 year ago

https://github.com/TakataSanshiro/Chocolatey-Packages/pull/97