search

TakeLab / spacy-udpipe

spaCy + UDPipe
MIT License
159 stars 11 forks source link

spaCy v3.0 support #33

Closed KoichiYasuoka closed 3 years ago

KoichiYasuoka commented 3 years ago

Tentative suport for spaCy>=3.0.0

KoichiYasuoka commented 3 years ago

Is this OK for issue #31 @asajatovic?

KoichiYasuoka commented 3 years ago

Umm... It seems that I need to change tests/test_spacy_udpipe.py for spaCy v3 when I change setup.py... But how do I do?

asajatovic commented 3 years ago

Umm... It seems that I need to change tests/test_spacy_udpipe.py for spaCy v3 when I change setup.py... But how do I do?

You want to increment SPACY_VERSION used for the (Romanian) morphology workaround test. For other failed tests, you can see the log here.

KoichiYasuoka commented 3 years ago

to_disk of spacy.language.Language seems quite different between v3 and v2, especially in serialization with/without JSON... Umm...

asajatovic commented 3 years ago

to_disk of spacy.language.Language seems quite different between v3 and v2, especially in serialization with/without JSON... Umm...

to_disk() is mocked so it is of no concern