TakhyunKim / closed-caption-extension

A Chrome extension that displays English subtitles for various pages, along with the subtitle of your choice.
https://chrome.google.com/webstore/detail/closed-caption-korean/pjfhdffkbjfneojiamjnooaagomkimde
18 stars 2 forks source link

Netflix 지원 #53

Closed TakhyunKim closed 1 year ago

TakhyunKim commented 1 year ago

🧐 What is this PR?

πŸ’» Changes

netflix μ‚¬μ΄νŠΈμ— λŒ€ν•œ 접근을 ν•  수 있게 κΆŒν•œ ν™•μž₯ 및 dom 정보λ₯Ό μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€. 4571b8d

netflix μ—μ„œλ§Œ 지원할 수 μžˆλŠ” λ³„λ„μ˜ λ Œλ”λ§ λ‘œμ§μ„ μΆ”κ°€ν•©λ‹ˆλ‹€. 6bf1e00

controller λ‚΄μ—μ„œ subtitle dom Wrapper dom 이 μ‘΄μž¬ν•˜λŠ”λ° textContent κ°€ 없을 경우, subtitle dom wrapper λ₯Ό μ‚­μ œν•˜λŠ” λ‘œμ§μ„ μΆ”κ°€ ad50dd5

πŸŽ₯ ScreenShot or Video

스크란샷 2023-04-10 α„‹α…©α„Œα…₯ᆫ 1 26 34
github-actions[bot] commented 1 year ago

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟑 Statements
64.88% (-9.39% πŸ”»)
133/205
πŸ”΄ Branches
26.67% (-6.67% πŸ”»)
8/30
🟑 Functions
62.75% (-3.21% πŸ”»)
32/51
🟑 Lines
68.25% (-9.95% πŸ”»)
129/189
Show files with reduced coverage πŸ”»
|
St.:grey_question:
| File | Statements | Branches | Functions | Lines | | :----------------------------------------------------------------------------------------------------------------------------------------------------: | :------------------ | :------------------------------------------------------------ | :------------------------------------------------------------ | :------------------------------------------------------------ | :------------------------------------------------------------- | | 🟑 | view/index.ts |
72.09% (-27.91% πŸ”»)
|
58.33% (-41.67% πŸ”»)
|
81.25% (-18.75% πŸ”»)
|
72.5% (-27.5% πŸ”»)
| | πŸ”΄ | controller/index.ts |
55.26% (-6.5% πŸ”»)
|
12.5% (-7.5% πŸ”»)
| 66.67% |
56.76% (-6.88% πŸ”»)
|

Test suite run success

29 tests passing in 4 suites.

Report generated by πŸ§ͺjest coverage report action from ad50dd58818e53e7017cf9a74854097a7a674970

TakhyunKim commented 1 year ago

λ„·ν”Œλ¦­μŠ€μ˜ 경우, λ‹€λ₯Έ μ‚¬μ΄νŠΈμ™€ 달리 μžλ§‰ wrapper dom 이 μˆ˜μ‹œλ‘œ μž¬λ Œλ”λ§μ΄ λ©λ‹ˆλ‹€. 이둜 인해 κΈ°μ‘΄ μžλ§‰ wrapper dom ν•˜μœ„μ— λ²ˆμ—­λœ wrapper dom 을 μΆ”κ°€ν•˜λŠ” 방식을 μ‚¬μš©ν•  수 μ—†μŠ΅λ‹ˆλ‹€. 그둜 인해 netflix ν•œμ •μœΌλ‘œ μ‚¬μš©ν•˜λŠ” render 방식을 μΆ”κ°€ν•˜μ—¬ μš°μ„  μ μš©ν•©λ‹ˆλ‹€.

[기술 뢀채] λ„·ν”Œλ¦­μŠ€ μš”μ²­μ— λŒ€ν•œ λŒ€μ‘ PR - μ°¨ν›„ κ°œμ„  ν•„μš”