Takingroot / co2r

Website for the CO2R platform
http://co2r-demo.herokuapp.com/
0 stars 0 forks source link

Organization descripton on French artifacts displays EN text #173

Closed brookevmf closed 11 years ago

brookevmf commented 11 years ago

I just noticed that the organization text that displays when viewing the French version of the site is actually the English content.

Screen Shot 2013-04-12 at 5 07 06 PM

jasonkuhrt commented 11 years ago

Screen Shot 2013-04-14 at 8 30 06 PM

Ah, we need a new translation field, that's why. Re-tagged and re-assigned. Assign back to me when the field is ready.

pdr commented 11 years ago

Added field (and translated it).

It should be - appText.artifact_organization_label

pdr commented 11 years ago

https://github.com/Takingroot/co2r-data/commit/2aaf58ed86bf4c46e56618e33e34aced9fa164a5

brookevmf commented 11 years ago

Hey guys, I still see English text on the French artifact page for the Organization description. See: http://new.co2r.com/coop1001facons

jasonkuhrt commented 11 years ago

@brookevmf This appears unrelated to the issue thread but whatever...

@pdr assigning you to. Looks like its on the api-side. Look at these two responses:

http://data.co2r.com/api/artifact/santropol http://data.co2r.com/api/artifact/santropol?language=fr

Notice that the second one (french) doesn't show french organization information.

pdr commented 11 years ago

Hey - this should be good to go now. http://data.co2r.com/api/artifact/santropol?language=fr

brookevmf commented 11 years ago

Looks great! Thanks guys.

@jasonkuhrt Really?? I wonder if we've been talking about different things this whole time then... haha. Oh well.

jasonkuhrt commented 11 years ago

@brookevmf Hilarious... @pdr and I thought this issue was about the locale for the word location meanwhile you were trying to talk about the organization description text from the start? Sorry haha.

pdr commented 11 years ago

I still have no idea what this one is :)

On May 9, 2013, at 8:12 PM, Jason Kuhrt notifications@github.com wrote:

@brookevmf Hilarious... @pdr and I thought this issue was about the locale for the word location meanwhile you were trying to talk about the organization description text from the start? Sorry haha.

— Reply to this email directly or view it on GitHub.

brookevmf commented 11 years ago

No worries, you've addressed what I wanted to have addressed, so it's all good!! haha.