TakuSemba / CropMe

Extremely Smooth and Easy Cropping library for you
Apache License 2.0
423 stars 74 forks source link

Issue with circle crop #13

Closed Soklundy closed 4 years ago

Soklundy commented 4 years ago

I have use app:cropme_overlay_shape="circle" but result is very zoom (Not the same with preview on crop screen)

TakuSemba commented 4 years ago

Thank you for the report. I will check into it.

lee-ngeap commented 4 years ago

Not only the circle, but also the rectangle.

TakuSemba commented 4 years ago

Thank you for the reporting.

Unfortunately, I could not reproduce the issue on my environment.

It would be really appreciated if you could reproduce it on the demo app in this repo and provide me the branch, and if possible I want a gif or image of the unexpected cropped image with an explanation of how it should be.

lee-ngeap commented 4 years ago

Anyways, your circle cropping is not right. The result not the same as in the preview while cropping. Please see attachment. Why the result is not circle, instead it's portrait?

Result: kropme_circle

Result display on the mobile screen: tempFileForShare_20191129-123653

Suppose to display on the mobile screen as per previewing while cropping: tempFileForShare_20191129-123817

lee-ngeap commented 4 years ago

Here is the original image. 20191129_093013

lee-ngeap commented 4 years ago

This one for rectangle: For the rectangle, the result is perfect. However, it's zoomed for the result display on the mobile.

Original: original

Result: result

Result display on the mobile screen: result display on the mobile

TakuSemba commented 4 years ago

Unfortunately, I could not reproduce the issue.

Please report these details below so that I can look into it.

I'm closing this issue just for now. Please reopen this with the detail information above, I am happy to help you.