TalAter / UpUp

✈️ Easily create sites that work offline as well as online
https://www.talater.com/upup/
MIT License
4.88k stars 264 forks source link

Throws a TypeError when service worker not supported #119

Open gavmck opened 6 years ago

gavmck commented 6 years ago

Expected Behavior

UpUp.start should fail silently when not supported.

Current Behavior

Throws an error: TypeError: null is not an object (evaluating 'UpUp.start')

Possible Solution

Still return an object from UpUp so you can call UpUp.start without it exploding.

Context

We catch JS errors in our app and forward to /error, which tries to load upup which causes a js error which forwards to /error in an infinite loop

Your Environment