search

TalAter / UpUp

✈️ Easily create sites that work offline as well as online
https://www.talater.com/upup/
MIT License
4.88k stars 264 forks source link

Cached videos do not play on safari #135

Open adamhughes86 opened 5 years ago

adamhughes86 commented 5 years ago

Expected Behavior

I expect the video to be accessible and played on safari

Current Behavior

When a video is played from the cache on safari it will not play. The first time you visit the site (video not cached) it will play fine

Possible Solution

It's possible that safari can't read the videos as it doesn't understand the response from the service worker. This article seems to go into more detail:

https://philna.sh/blog/2018/10/23/service-workers-beware-safaris-range-request/

I think UpUP may be able to change the range manually so that the videos will work

Steps to Reproduce (for bugs)

  1. Create a site with a service worker
  2. Add a video to the site and add the video to the cached assets
  3. Visit the website from Safari
  4. Test video (should work)
  5. Access the website again from offline
  6. Test video (won't work)

Context

Trying to cache videos for offline view but none will play on safari