fixed SpeechRecognition of undefined

TalAter / annyang

:speech_balloon: Speech recognition for your site

MIT License

6.57k stars 1.05k forks source link

Description

fixed SpeechRecognition of undefined

Motivation and Context

import annyang from "annyang"; And I get "Cannot read property 'SpeechRecognition' of undefined"

How Has This Been Tested?

localy

Types of changes

[x ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x ] All new and existing tests passed.

Hi @WebRitual ,

Thank you for the contribution and for taking the time to send in the pull request.

Unfortunately the code as submitted will break in browsers that do not support the SpeechRecognition API. It will also be a breaking change in what the library returns on initialization and will thus require a major version release (a 3.0.0 release). My concern is that even if we release a major version intended to support an import use case, the rest of the library wasn't designed to be imported that way as it was written quite some time ago. I think if we were to do a major version release like this it should entail a rewrite of the library to support importing it into modern codebases.

Any thoughts?

Thank you 🙏

TalAter / annyang