Call me an extremist but I think this is the solution! ES and regular search are fully aligned now: we could start processing the joined searches and back out of regular search and into ES if we encounter a Keyword Search term, but that seems wasteful and unnecessarily complicated.
While it has become redundant for now, I do think we should keep the code in regular search processing that would handle joined searches — it's not totally out the question that we would diverge from this approach in future.
But I'd be interested to get the team's view on that.
Also implemented Intellij recommendation to use .isEmpty() on keyword search.
Call me an extremist but I think this is the solution! ES and regular search are fully aligned now: we could start processing the joined searches and back out of regular search and into ES if we encounter a Keyword Search term, but that seems wasteful and unnecessarily complicated.
While it has become redundant for now, I do think we should keep the code in regular search processing that would handle joined searches — it's not totally out the question that we would diverge from this approach in future.
But I'd be interested to get the team's view on that.
Also implemented Intellij recommendation to use .isEmpty() on keyword search.