Talent-Catalog / talentcatalog

https://tctalent.org
GNU Affero General Public License v3.0
12 stars 4 forks source link

IELTS score of 0 not showing on List view #1250

Closed samschlicht closed 2 months ago

samschlicht commented 2 months ago

As a TC admin I want to see scores of 0 for candidates who've taken the exam So it's easier at a glance to see who has done it and who hasn't

From Lea: Hi <@U055YR1QT0A> <@U02NYRN57V5> In the screenshot below you will see that the English assessment was done with the candidate but has an IELTS of 0. However the "0" is not showing in the list under IELTS score, and only shows starting IELTS 1. This is a bit confusing as it can be misunderstood to mean that the English assessment was not actually done with the candidate. Is there anyway we can start making it show as 0 in the lists? <!subteam^S06MQJ4GA8P>

Slack Message

samschlicht commented 2 months ago

In javascript, 0 is falsey. Just need to change condition check on getIeltsScore() to process 0:

Screenshot 2024-08-20 at 5.29.06 PM.png
samschlicht commented 2 months ago

And done:

Screenshot 2024-08-20 at 5.31.51 PM.png Screenshot 2024-08-20 at 5.32.34 PM.png