search

TalentBox / sequel-rails

A gem for using Sequel with Rails 5.x, 6.x, 7.x, 8.x
http://talentbox.github.io/sequel-rails/
MIT License
326 stars 81 forks source link

Spring support for Rails 5.1 #132

Closed tyok closed 7 years ago

tyok commented 7 years ago

The spring support code uses alias_method_chain which has been deprecated in Rails 5.1.0.beta1.

mikeyhew commented 7 years ago

I'm getting the feeling that TalentBox won't merge this PR because they want to support ancient versions of Ruby. Considering the fact that #125 was merged 6 months ago, which adds stuff specific to Ruby 1.9.x

JonathanTron commented 7 years ago

Hi @tyok, @mikeyhew and @art-solopov.

I've simply replaced the alias_method_chain by the equivalent alias_method invocations... this works across ruby/rails versions.

JonathanTron commented 7 years ago

@mikeyhew

I'm getting the feeling that TalentBox won't merge this PR because they want to support ancient versions of Ruby. Considering the fact that #125 was merged 6 months ago, which adds stuff specific to Ruby 1.9.x

I'm willing to drop support for older ruby versions (< 2.2), I will create a 0.9.x-stable branch from the current master and then we can start looking at what code we can remove... but I suspect there's not so much which would change, it will mainly reduce the TravisCI time (which is a good thing).

art-solopov commented 7 years ago

Thank you very much @JonathanTron!

JonathanTron commented 7 years ago

You're welcome @art-solopov, I'll try to get the CI green and then cut a new 0.9.x release.

mikeyhew commented 7 years ago

@JonathanTron

I'm willing to drop support for older ruby versions (< 2.2), I will create a 0.9.x-stable branch from the current master and then we can start looking at what code we can remove [...]

That's good news! It will make me more enthusiastic about contributing :smile:

tyok commented 7 years ago

Thanks, alias_method_chain makes me dizzy. I can't believe the workaround is that simple!