Handle missing database

TalentBox / sequel-rails

A gem for using Sequel with Rails 5.x, 6.x, 7.x, 8.x

http://talentbox.github.io/sequel-rails/

MIT License

326 stars 81 forks source link

Closed steveh closed 7 years ago

steveh commented 7 years ago

This patch makes sequel-rails behave a bit more like ActiveRecord.

db:setup should be more resilient in that it won't fail to drop a database that doesn't exist.

Certain combinations of database.yml, ENV["DATABASE_URL"] and JDBC will now succeed when the port defaults to zero.

JonathanTron commented 7 years ago

Hi @steveh, thanks for this great Pull Request !

steveh commented 7 years ago

Thanks @JonathanTron! I see that you released v0.9.16 which has this PR in the release notes, but it doesn't seem to actually be included in that release? https://github.com/TalentBox/sequel-rails/compare/v0.9.16...master

JonathanTron commented 7 years ago

@steveh You're right, I've messed up this release somehow... I'm fixing it and will release 0.9.17.

Thanks for catching it.