search

Talesoft / tale-jade

A complete and fully-functional implementation of the Jade template language for PHP
http://jade.talesoft.codes
MIT License
88 stars 10 forks source link

Hyperlinks are not displaying correctly #106

Closed vnddr closed 8 years ago

vnddr commented 8 years ago

Looks like one of the last commits broke something with hyperlinks. Link elements started to get their DOM parents’ classes. Some interface details like avatars (which are the links to the profile) started to appear different and changed their location. The problem showed up in https://github.com/Talesoft/tale-jade/commit/c73aa60fef6e3ca1b18aa5dde434fec39618de7f.

TorbenKoehn commented 8 years ago

This probably happened in f8e765f83d4b1d2318d4811681a434f02fa30b4b

I changed the whitespace handling, it didn't match official Jade's.

Can you give me some examples or screenshots?

If you e.g. use icons and they are dislocated, you probably had something like

a(href='#')
    i.fa.fa-fw.fa-gear
    | Some text

which automatically added a whitespace between the icon and the text.

It doesn't do this anymore, but you can use multiple whitespaces (only the first one is ignored now)

a(href='#')
    i.fa.fa-fw.fa-gear
    |  Some text

to get the same effect (Notice that Some has two whitespaces in front of it)

TorbenKoehn commented 8 years ago

Any update on this?

TorbenKoehn commented 8 years ago

I'll close this. If you have any further questions, re-open it please.