search

Talesoft / tale-jade

A complete and fully-functional implementation of the Jade template language for PHP
http://jade.talesoft.codes
MIT License
88 stars 10 forks source link

_options ? #64

Closed jacmoe closed 8 years ago

jacmoe commented 8 years ago

I am using 1.4.0 and it looks like Compiler, Lexer, Parser and Renderer still uses the $_options variable instead of $options.

I fixed it by doing a simple search and replace.

The old Configuration class used $_options but the tale-config package uses $options.

I could issue a PR, but I thought I'd check in and see why other people are not getting this error.

TorbenKoehn commented 8 years ago

Yep, that was my error when I changed the tale-config api yesterday.

I will merge a hotfix for master in a few minutes.

TorbenKoehn commented 8 years ago

Can you test it now?

What needs to happen is that tale-jade uses tale-config 0.1, not 0.2. You might need to re-install tale-jade and tale-config (just delete vendor/talesoft and composer.lock and run composer update)

I re-created the 0.1 with the new changes yesterday when I realized that tale-jade needs 0.1 right now. I updated the code style conventions to PSR-2 (no _ before privates) The PSR-2 version of tale-config is 0.2 now.

jacmoe commented 8 years ago

Fixed - thanks! :+1:

I don't think that tag 0.4.0.1 is kosher with Composer, so I just use dev-masterfor tale-jade now. :)

TorbenKoehn commented 8 years ago

Yup, seems like it.

It's 1.4.1 now, the next version will be 1.5 and will be released in a few days.

It's a full overhaul.

jacmoe commented 8 years ago

It's a full overhaul.

You are busy :+1:

Looking forward to it!