search

Talesoft / tale-jade

A complete and fully-functional implementation of the Jade template language for PHP
http://jade.talesoft.codes
MIT License
88 stars 10 forks source link

support comment // if IE 8? #75

Closed DavidKk closed 8 years ago

DavidKk commented 8 years ago

it only compile to not

TorbenKoehn commented 8 years ago

Generally, yes, you are right.

But you don't use //-style-comments for IE-conditionals, you use the fact that Tale Jade also handles normal HTML markup (When the line starts with <, it's handled as plain-text)

Watch this: http://sandbox.jade.talesoft.io/id-57060fbfe2450.html

There is an error, though, the ![endif] gets handled as interpolation. I thought I fixed it but I did it wrong. I already made it not interpolating it, but it forgets the ![] :D

I will bring up a hotfix soon.

TorbenKoehn commented 8 years ago

This should be fixed with 1.4.2

Can you test it and give me feedback?

TorbenKoehn commented 8 years ago

The tests say it works, please re-open this if it doesn't :)