Talia-12 / Hexal

Extension mod for Hex Casting to add new patterns (and whatever else I feel like).
MIT License
13 stars 21 forks source link

A cyclic wisp spawning 2 other cyclic wisps in the same tick falsely triggers a recursion-depth fault #56

Closed computer-whisperer closed 1 year ago

computer-whisperer commented 1 year ago

Here is a simple reproducing spell

image

It took me many many hours to figure out that this was why my power distribution wisps were occasionally crashing...

Seen with the modpack "All of Fabric 6" versions 1.5.2 and 1.5.4. Minecraft 1.19.2, Hex Casting 0.10.3 Hexal 0.2.14, Fabric API v0.76.0+1.19.2

Talia-12 commented 1 year ago

this is intentional, but I should really make the error message clearer; basically, wisps can only make at most 1 new wisp each tick, to prevent fork-bomb issues.

Talia-12 commented 1 year ago

alright, made a mishap with a clearer error message for this