Talia-12 / MoreIotas

An addon for Hex Casting, adding new types of iotas such as Strings.
MIT License
1 stars 7 forks source link

Matrix size documentation is inconsistent and confusing #12

Closed object-Object closed 1 year ago

object-Object commented 1 year ago

Preface: The width of a matrix is the number of columns. The height of a matrix is the number of rows. Generally, this is denoted m × n, where m is the height (rows) and n is the width (columns). The iota string representation uses this order. https://github.com/Talia-12/MoreIotas/blob/71e0b2c36f7a34ce2e332094882ab114557c32d6/Common/src/main/java/ram/talia/moreiotas/api/spell/iota/MatrixIota.java#L93

This is not explicitly stated anywhere in the book (unless I missed it), and some of the pattern docs don't follow this convention. For example, it's reversed in the descriptions of Tower and Sprawling: image As an aside, the fact that m and n are swapped here is also very confusing.

Meanwhile, Transformation uses the correct order: image

Talia-12 commented 1 year ago

Fixed for the next release.