TalismanSociety / talisman

Multi-Chain Made Easy with Talisman Wallet. An ultra-secure Ethereum and Polkadot wallet for both beginners and pros.
https://talisman.xyz/download
GNU General Public License v3.0
57 stars 37 forks source link

Bridge Hub Integration: View bridged assets from in Asset Hub in Wallet #1308

Closed alistair-singh closed 1 month ago

alistair-singh commented 8 months ago

Fearture request: A user should be able to see any bridged assets that they own in their wallet.

Asset Hub now supports foreign assets bridged through Bridge Hub. These assets are stored in a different instance of the assets pallet called ForeignAssets from version 1.7 release of Asset Hub.

There are two bridges currently deployed in Rococo

  1. Snowbridge (bridges to Sepolia Ethereum testnet)
  2. Westend Bridge (bridges to Westend substrate based testnet)

For Snowbridge the token that is Bridged is WETH (Wrapped Ether). Please see docs for more information on how to interact with the bridge and query asset balances.

We have plans for launch in Kusama and Polkadot (bridging to Ethereum mainnet) by the end of March.

chidg commented 8 months ago

Thanks for bringing this to our attention @alistair-singh. I'll raise it with our product team and we will prioritise; in the meantime, you are welcome to submit a PR to our balances modules to help us support the ForeignAssets pallet.

cc asset support superstar @alecdwm

musnit commented 7 months ago

@chidg @alecdwm FYI SubWallet has added support for foreign assets here: https://github.com/Koniverse/SubWallet-Extension/commit/3218c6f2880c9f037116873e9699a124fda84dde - hopefully code is useful as a reference

musnit commented 4 months ago

@chidg bump on this. we are now live on polkadot mainnet (https://app.snowbridge.network/) and users can't see their assets in their wallet due to lack of foreign asset support.

alistair-singh commented 2 months ago

@chidg bump on this. There are now a few assets stored in the foreign assets pallet on mainnet Asset Hub.

Subscan has added support as well: https://assethub-polkadot.subscan.io/foreign_assets

Assets bridged by Snowbridge: WETH WBTC USDC USDT

Assets bridged by Polkadot-Kusama bridge: KSM

Non bridged assets: MYTH HDX GLMR

For bridged assets that conflict with other assets such as USDC and USDT, you can use USDC.e or USDC-Snowbridge to differentiate them.

nicolares commented 2 months ago

Hey all! Thanks for adding support for WETH from snowbridge.

In addition that (I already flagged this with @jonathanpdunne but bumping here in case it helps) Turtle is already live but users are not seeing their USDC.e and USDT.e balances. Currently only Subscan supports all of them and not in the "neatest" way so hopefully you guys can help out by adding all available foreign assets too 🙏

alecdwm commented 1 month ago

Hey @nicolares!

We didn't realise there would be foreign assets which could be queried via ForeignAssets.Asset and not ForeignAssets.Metadata.

We've added the missing ones, including the aforementioned WETH, WBTC, USDC, USDT, KSM, MYTH, HDX, GLMR as well as PEPE, TBTC, WSTETH, TONCOIN, DAI and SHIB.

chidg commented 1 month ago

Closed as complete For future assets when no metadata present, they'll need to be added manually - please contact us if so