search

TalismanSociety / talisman

Multi-Chain Made Easy with Talisman Wallet. An ultra-secure Ethereum and Polkadot wallet for both beginners and pros.
https://talisman.xyz/download
GNU General Public License v3.0
56 stars 35 forks source link

Remove chrome icon badge text #570

Open SwamiTLSM opened 1 year ago

SwamiTLSM commented 1 year ago

Icon badges are currently always danger-red and have limited space for characters, often truncating the word.

From this reddit post: https://www.reddit.com/r/Polkadot/comments/11awrg6/red_asset_warning_on_browser_plugin/:

j1w3guha76ka1 - this should say Assets not Asset! (the s is truncated to look like a !). It looks as if something bad is happening.

It would be good if we could:

  1. Have more nuanced control of the badge color based on notification type and importance (setBadgeBackgroundColor)
  2. Find words which fit into the space available (max 4 or 5 chars)
  3. Show the issue to the user when opening the wallet
chidg commented 1 year ago

It's even worse on Firefox Screenshot 2023-03-01 at 11 59 23 am

Because we can only really show three letters on FF, I think we just accept that they're going to get truncated. Colour change is an option though -> let's talk to fontbois.

chidg commented 1 year ago

Show the issue to the user when opening the wallet

Currently it is; the request should appear in the popup when it's opened. However there is a plan afoot to clear these requests when the popup is closed. This would not solve the problem where the popup is in the background behind another window, which is quite possibly the case for this user.

0xKheops commented 1 year ago

looks this "feature" is meant to display a number (of notifications)

chidg commented 1 week ago

Remove the badge!