search

TalkbackTutorial / Application

An Android App as Talkback Tutorial.
6 stars 2 forks source link

OpenVoiceCommandPart2Fragment is unused. #87

Closed Andre-Pham closed 2 years ago

Andre-Pham commented 2 years ago

OpenVoiceCommandPart2Fragment isn't used anywhere and crashes the application. This should either be referenced where it's needed or removed entirely if it's not being used.

If it is being kept, val currentLesson : Lesson = LessonContainer.getAllLessons()[4] needs to be changed to use .getLesson. This is a risk because if any lesson is added prior to this one, the code breaks.

jaiclapp commented 2 years ago

Missing lines of code were deleted during the merge. These lines have been added back in and OpenVoiceCommandPart2Fragment is now referenced again. The finish lesson component of OpenVoiceCommandPart2Fragment has been updated to fit a better design and is more inline with other fragments. Now up for review.

jaiclapp commented 2 years ago

This issue has been reviewed and completed.