search

TallWorlds / CubicChunks

MIT License
36 stars 7 forks source link

All chat messages appear twice #14

Closed Valiec closed 9 years ago

Valiec commented 9 years ago

Just like the title says, all messages printed to the chat appear twice. There are no spaces or newlines between the duplicate outputs.

Example: I was setting the time to 1000 (I didn't want it to be night in my testing world). I did "/time set 1000" and this was outputted in the chat:

"Set the time to 1000Set the time to 1000"

Drayux commented 9 years ago

Same here, man! I got the error just with the magic mojo launcher alone... it was before I installed cubic chunks. I am not an advanced programmer, nor am I developing this, but it is likely caused by something to do with forgetting a line break in the code and/or reusing an output string...something. XD

mikesmiffy128 commented 9 years ago

eh... Forgetting a line break in Java has no effect on anything. If it did there would be a compile error. Plus you can't really forget a line break. The return key is the biggest key on a keyboard. This is probably caused by a missing client / server context check somewhere which means the chat rendering code is called from both sides. I don't even know what causes this any more. Anyway, for some reason M3L inherits the same odd design of Forge by which identical code is run on a client and server (Is it a vanilla thing too? It just seems so daft).

Oh, while I'm here, I may as well confirm that I also experienced this issue a while ago and I did assume it was probably M3L rather than Tall Worlds causing it. To be honest it would be logical to close this issue and reopen it over on Bitbucket, but it doesn't matter much really.

ajthemacboy commented 9 years ago

Can confirm. Also happens when hovering over achievements in chat; the description is doubled.

mikesmiffy128 commented 9 years ago

Hovering over achievements? Well that's... just weird.

AttackOfTheDirt commented 9 years ago

That is m3l not the tall worlds mod. Happened to me with m3l beta 0.1 without the tall worlds mod. Put this issue for m3l not tall worlds.

AttackOfTheDirt commented 9 years ago

M3l causes this.

AttackOfTheDirt commented 9 years ago

I reported this issue for m3l on the m3l fprum thread already. Skin customisation and twitch broadcasting text gets duplicated so does the text that appears when a server log in fails. I have also already uploaded screenshots on the m3l forum thread. I have already reported this idsue on the minecraft forums.

AttackOfTheDirt commented 9 years ago

Mikesmithy 128 is 100% correct about it being m3l issue, just I have already reported this issue and EVERYTHING about it on the m3l minecraft forum thread. First m3l issue ever reported was me reporting text duplication on the minecraft forum m3l thread.

mikesmiffy128 commented 9 years ago

Oh God! Calm down mate! You don't need to post 4 replies in a row saying the same thing. By the way, I linked the BitBucket bug tracker for a reason. Reporting on the forum probably works too, but there are existing issues on the BitBucket so you're wrong about it being the first issue ever reported. lol

Seriously though, mind the spam; keep in mind everyone gets an email whenever someone replies.

Razaekel commented 9 years ago

M3L issue.