search

TallerWebSolutions / apollo-cache-instorage

Apollo Cache implementation that facilitates locally storing resources
MIT License
96 stars 11 forks source link

Fixing empty data responses for queries #7

Closed EmilyHwang closed 5 years ago

EmilyHwang commented 5 years ago

https://github.com/TallerWebSolutions/apollo-cache-instorage/issues/6?_pjax=%23js-repo-pjax-container

InMemoryCache reads responses for queries from optimistic data which currently is empty. With this fix, the responses are read from the correct data set. InMemoryCache does something similar in overwriting both optimisticData and data

codecov-io commented 5 years ago

Codecov Report

Merging #7 into master will increase coverage by 0.05%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
+ Coverage   91.33%   91.39%   +0.05%     
==========================================
  Files           6        6              
  Lines         150      151       +1     
  Branches       43       43              
==========================================
+ Hits          137      138       +1     
  Misses          7        7              
  Partials        6        6
Impacted Files Coverage Δ
src/inStorageCache.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3364491...ebb2c8d. Read the comment docs.

lucasconstantino commented 5 years ago

Thanks for that. I'm asking some people to have a look and validate if it fixes their issues ;)

lucasconstantino commented 5 years ago

@EmilyHwang by the way: welcome to GitHub ;)