search

Tallwave / Sargon-QA

0 stars 0 forks source link

Home page, in the modules where we have the Instagram and LinkedIn logos, it's missing an external link (new window) to each of the social sites (and the small ext-link icon in the lower-right corner of each). #14

Open pguevara65 opened 5 years ago

pguevara65 commented 5 years ago

https://drive.google.com/file/d/11sY4nkviGYd4vofmSBBcBkWs8rQZBALq/view?usp=sharing

Links: https://www.instagram.com/sargon_masonry/ https://www.linkedin.com/company/sargon-masonry/about/

See UI kit page 2 for interaction/hover state.

Jason's comment after submission: The hover and icon look good.

But let's update so both external links open in a new tab.

NoelWormwood commented 5 years ago

@cmoosman1 Only Remaining Item:let's update so both external links open in a new tab

cmoosman1 commented 5 years ago

@pguevara65 - This is resolved in the current build

pguevara65 commented 5 years ago

@NoelWormwood let me know if you want me to review

NoelWormwood commented 5 years ago

@jthiel16 Please review

jthiel16 commented 5 years ago

@cmoosman1 Let's update so both external links open in a new tab.

cmoosman1 commented 5 years ago

@NoelWormwood - This is resolved will msg in basecamp when I push