search

TalonBraveInfo / invasion

Team Fortress: Invasion brought over to Source 2013.
http://www.talonbrave.info/
Other
19 stars 5 forks source link

Hard-coded Directories make compilation difficult #25

Closed legoj15 closed 5 years ago

legoj15 commented 5 years ago

Hello there, I was trying to compile some release DLLs, but there seems to be something that wants to point to "H:\InvasionSource\mp\src\game\server\" and "H:\InvasionSource\mp\src\game\client\". even after re-running VPC

In the files server_hl2mp.vcxproj and client_hl2mp.vcxproj, there is this string in the "PreprocessorDefinitions" block: PROJECTDIR=H:\InvasionSource\mp\src\game\server & PROJECTDIR=H:\InvasionSource\mp\src\game\server

Ideally, the GitHub repo shouldn't have the files that VPC generate (i.e the .sln, the .vcxproj files), and any changes to the project files should be added to their respective .vpc files so that when VPC is ran, the .vcxproj files are created exactly how you want them to be already (which, I see that you have done already judging by the diffs of the .vpc files between this repo and the SDK 2013 repo)

This isn't a crucial issue in the slightest, as simply deleting all the .vcxproj files and rebuilding them with VPC will fix it, but it could cause issues if the person compiling does not know that.

Juesto commented 5 years ago

Or, you could remove VPC blocking mechanisms from the projects such as this annoying preprocessor definition.

hogsy commented 5 years ago

I'm well aware of this and it's already on my todo list.

hogsy commented 5 years ago

fixed