TalonCommunity / Wiki

Community maintained wiki for Talon Voice
https://talon.wiki
80 stars 80 forks source link

Make header not sticky #241

Closed adiabatic closed 6 months ago

adiabatic commented 6 months ago

This makes the site header not sticky. Sticky headers are an annoyance for people who scroll one screenful at a time:

I also normally scroll down using the space key, which scrolls just less than one full viewport at a time. When you cover up part of your content with a sticky element, that means that the space key scrolls too far down. Then I lose my position and have to scroll back up.

If there's no sticky header, I just need to say space to continue reading.

If there's a sticky header, then I have to say space, lose the place on the page where I was reading, then say go up twice, then continue reading. Every single time I'm scrolling down one page.

If I happen to want something in the header — which isn't often compared to how often I scroll down reading a page — I can press the Home key or say home or scroll to top, depending on whether I'm using Talon, Windows Speech Recognition, or Voice Control.

netlify[bot] commented 6 months ago

Deploy Preview for talon-wiki-refactor ready!

Name Link
Latest commit 20d3b4048d7489135d99fa5fe32c3d99bc5d266b
Latest deploy log https://app.netlify.com/sites/talon-wiki-refactor/deploys/65fb7cd4ec080200084ff4b8
Deploy Preview https://deploy-preview-241--talon-wiki-refactor.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

C-Loftus commented 6 months ago

Behavior works as intended. Going to work to get a second opinion before merging. I honestly am not sure which is better

C-Loftus commented 6 months ago

That being said, thank you obviously for adding this. Just want to be totally sure and have a larger sample size

adiabatic commented 6 months ago

To figure out if you like the change I've proposed, I suggest going to the version of the site with the sticky header and trying to read and understand a page or three with just page-up and page-down actions (space, shift space, page up, page down, etc.). To make sure you're getting the effect, ensure your browser window is small enough to require you to page-down multiple times per page. If the annoyance of losing your place while reading doesn't convince you, nothing will.

On the other hand, if you've been knee-deep in Talon docs, you've probably nearly memorized everything here. You'd need to read something else, otherwise you're liable to skim the information there because you've mostly seen it already.

C-Loftus commented 6 months ago

I do see what you are mentioning. I think it is fair, I just want to get another opinion to be sure The main thing I don't like is how it appears on mobile. Then others have to scroll up the entire way to access the menu

mobile image

desktop w/ vs wo/ header image image

C-Loftus commented 6 months ago

Ok I have added this. I am using the built in docusaurus feature instead of the CSS since docusaurus handles a few css edge cases with that a bit nicer. It makes it not sticky but brings it back if you scroll up which we want for mobile, otherwise they have to scroll up the entire phone screen which isn't really practical

Addressed in: https://github.com/TalonCommunity/Wiki/pull/246