TalonCommunity / Wiki

Community maintained wiki for Talon Voice
https://talon.wiki
80 stars 80 forks source link

Update getting_started.md #280

Closed graydon closed 4 months ago

graydon commented 4 months ago

I'm not actually sure this will work when rendered to the wiki. relative links on the wiki look like they're done differently than relative links inside the repository, and like .. it turns documents into directories or something? maybe it'd be best to just not use relative links?

netlify[bot] commented 4 months ago

Deploy Preview for talon-wiki-refactor ready!

Name Link
Latest commit 0ab4c9f1f4a1de5b8d3cc30d7b9557148d14271f
Latest deploy log https://app.netlify.com/sites/talon-wiki-refactor/deploys/6657a7d72ab9850008e0ab13
Deploy Preview https://deploy-preview-280--talon-wiki-refactor.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

C-Loftus commented 4 months ago

What is this change for? I don't believe the link is broken. The links are rendered via docusaurus so there are some differences / added flexibility with links. I wasn't using absolute links since they break a lot whenever a page or folder is renamed and the vscode extension doesn't have auto updates for docusaurus markdown changes.

graydon commented 4 months ago

What is this change for? I don't believe the link is broken. The links are rendered via docusaurus so there are some differences / added flexibility with links. I wasn't using absolute links since they break a lot whenever a page or folder is renamed and the vscode extension doesn't have auto updates for docusaurus markdown changes.

Go to this page where it's rendered: https://talon.wiki/quickstart/getting_started/ Scroll down to "Other user file sets" The link points to the broken destination https://talon.wiki/quickstart/Integrations/talon_user_file_sets

C-Loftus commented 4 months ago

Great, thanks. Missed that. Not sure why docusaurus didn't fail due to a broken link in CI. Normally it throws an error.