TalonFloof / EnhancedWeather

Adds Localized Weather Systems to Minecraft
https://modrinth.com/mod/enhanced-weather
MIT License
19 stars 3 forks source link

JourneyMap support for weather radar #12

Closed Steveplays28 closed 1 year ago

Steveplays28 commented 1 year ago

Is your feature request related to a problem? Please describe. JourneyMap has a minimap which has an API that probably supports custom overlays.

Describe the solution you'd like A JourneyMap overlay on the minimap/fullscreen map which displays the weather, like there's overlays for the biomes, topology, etc

Describe alternatives you've considered Xaero's Minimap, doesn't have an API and is closed source

Additional context Weather radar WIP dev screenshot of weather radar

image JourneyMap minimap screenshot

These two images but merged together would be cool!

TalonFloof commented 1 year ago

@Steveplays28 Screenshot from 2022-10-21 17-31-01 Looks like the API hasn't updated since 1.12... Not sure if that means that it hasn't changed since then, or if that means it's not possible.

UPDATE: Wait never mind, looks like it is possible.

TalonFloof commented 1 year ago

@Steveplays28 Check this out (Sorry for the low quality, GitHub only allows files to be up to 10 MiB >_<)

Steveplays28 commented 1 year ago

:o looks cool! nice work

TalonFloof commented 1 year ago

Thanks! Just curious if there's anything I can approve on. If not I'll push the commit for this and close this issue.

Steveplays28 commented 1 year ago

Maybe adding a toggle at the top bar of JourneyMap would be nice, not really sure what else at the moment. Also, is that an overlay for thunder? Or did I interpret that incorrectly?

TalonFloof commented 1 year ago

Maybe adding a toggle at the top bar of JourneyMap would be nice, not really sure what else at the moment.

I could maybe do that, let me see

Also, is that an overlay for thunder? Or did I interpret that incorrectly?

The overlay works with all storms, not just thunder, so it's basically the same as the weather radar.

Steveplays28 commented 1 year ago

Ah okay nice!

TalonFloof commented 1 year ago

Added a button to toggle the overlay. 2022-10-22_15 50 50

Steveplays28 commented 1 year ago

Awesomee! Great work dude, thanks I'll close the issue then